-
Notifications
You must be signed in to change notification settings - Fork 57
feat: text to speech (#546) #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply changes to all applicable places, I didn't repeated these comments. But overall, it looks really cool, these suggestions are just very small nits ;)
packages/react-native-executorch/common/rnexecutorch/data_processing/Sequential.h
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Sequential.h
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Decoder.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Decoder.h
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Constants.h
Show resolved
Hide resolved
...act-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/DurationPredictor.cpp
Show resolved
Hide resolved
...act-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/DurationPredictor.cpp
Outdated
Show resolved
Hide resolved
...ges/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Partitioner.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Utils.cpp
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Utils.cpp
Outdated
Show resolved
Hide resolved
571fada to
9eb0629
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits for the moment, I feel like we need to add docs to have a solid understanding of the public API layer. However, this looks like really a lot of solid work, congrats!
Haven't finished reviewing tho :D
Removed unnecessary Log.h include from RnExecutorchInstaller.h
Removed unnecessary iostream include from BaseModel.cpp
9eb0629 to
2b633eb
Compare
packages/react-native-executorch/src/modules/natural_language_processing/TextToSpeechModule.ts
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/src/modules/natural_language_processing/TextToSpeechModule.ts
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/src/modules/natural_language_processing/TextToSpeechModule.ts
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/src/modules/natural_language_processing/TextToSpeechModule.ts
Outdated
Show resolved
Hide resolved
...act-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/DurationPredictor.cpp
Outdated
Show resolved
Hide resolved
...react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/DurationPredictor.h
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Encoder.h
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Encoder.h
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Kokoro.cpp
Show resolved
Hide resolved
packages/react-native-executorch/src/modules/natural_language_processing/TextToSpeechModule.ts
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/src/modules/natural_language_processing/TextToSpeechModule.ts
Outdated
Show resolved
Hide resolved
3871e1e to
90ec4b9
Compare
| std::priority_queue<std::pair<float, int>> | ||
| remainders; // Sorted by the first value | ||
| int64_t scaledSum = 0; | ||
| for (int i = 0; i < nTokens; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change int to uint32_t



Description
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes
There are still a few side things to be done on this feature.