Skip to content

Conversation

@IgorSwat
Copy link
Contributor

@IgorSwat IgorSwat commented Jan 9, 2026

Description

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

There are still a few side things to be done on this feature.

@IgorSwat IgorSwat requested a review from mkopcins January 9, 2026 08:46
Copy link
Member

@msluszniak msluszniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply changes to all applicable places, I didn't repeated these comments. But overall, it looks really cool, these suggestions are just very small nits ;)

@IgorSwat IgorSwat force-pushed the @is/text-to-speech branch from 571fada to 9eb0629 Compare January 9, 2026 13:58
@msluszniak

This comment was marked as resolved.

Copy link
Contributor

@chmjkb chmjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits for the moment, I feel like we need to add docs to have a solid understanding of the public API layer. However, this looks like really a lot of solid work, congrats!

Haven't finished reviewing tho :D

@msluszniak
Copy link
Member

Please also fix all the alerts that are right now.
execu

@msluszniak msluszniak added the feature PRs that implement a new feature label Jan 13, 2026
@IgorSwat
Copy link
Contributor Author

Please also fix all the alerts that are right now. execu

image No alerts on my screen 🤷

@msluszniak msluszniak linked an issue Jan 13, 2026 that may be closed by this pull request
Comment on lines +126 to +129
std::priority_queue<std::pair<float, int>>
remainders; // Sorted by the first value
int64_t scaledSum = 0;
for (int i = 0; i < nTokens; i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change int to uint32_t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature PRs that implement a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text-to-Speech

4 participants