Skip to content

fix: android manifest config generated by plugin #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdydek merged 2 commits into from
Jan 16, 2026
Merged

fix: android manifest config generated by plugin #894

mdydek merged 2 commits into from
Jan 16, 2026
+16 −6

Conversation

@michalsek
Copy link
Member

@michalsek michalsek commented Jan 16, 2026 •
edited by maciejmakowski2003
Loading

Closes #890
Closes #892

Introduced changes

  • fixes FSG name in android manifest edits generated by the plugin
  • fixes duplicated FSG entries when plugin is re-run on same manifest file

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@michalsek michalsek self-assigned this Jan 16, 2026
@michalsek michalsek added bug Something isn't working fix labels Jan 16, 2026
@mdydek mdydek merged commit c65506a into main Jan 16, 2026
3 checks passed
@mdydek mdydek deleted the fix/plugin-android-fgs branch January 16, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdydek mdydek mdydek approved these changes

@maciejmakowski2003 maciejmakowski2003 maciejmakowski2003 approved these changes

@poneciak57 poneciak57 Awaiting requested review from poneciak57

Assignees

@michalsek michalsek

Labels

bug Something isn't working fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notification persists if the app is killed abruptly Audio recording becomes silent when the app moves to the background.

4 participants

@michalsek @mdydek @maciejmakowski2003