Skip to content

Fix/return session activation errors #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michalsek merged 2 commits into from
Jan 16, 2026
Merged

Fix/return session activation errors #891

michalsek merged 2 commits into from
Jan 16, 2026

Conversation

@michalsek
Copy link
Member

@michalsek michalsek commented Jan 16, 2026 •
edited
Loading

Closes #

⚠️ Breaking changes ⚠️

  • setAudioSessionActivity now throws on failure attempts

Introduced changes

  • retruns (through promise reject) a error code and additional details about why the activity failed

Testing

  • Easiest way to repro the error path, is to run some voice/video call app (f.e. google meet) then try to start the playback or recording from within the fabric example. It should throw the insufficient priority error in this case

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@michalsek michalsek self-assigned this Jan 16, 2026
@michalsek michalsek merged commit a5f1d96 into main Jan 16, 2026
3 checks passed
@michalsek michalsek deleted the fix/return-session-activation-errors branch January 16, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poneciak57 poneciak57 poneciak57 approved these changes

@mdydek mdydek Awaiting requested review from mdydek

@maciejmakowski2003 maciejmakowski2003 Awaiting requested review from maciejmakowski2003

Assignees

@michalsek michalsek

Labels

fix improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalsek @poneciak57