Skip to content

fix: old arch spec #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maciejmakowski2003 merged 1 commit into from
Jan 15, 2026
Merged

fix: old arch spec #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../android/src/main/java/com/swmansion/audioapi/system/notification/PlaybackNotification.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import android.support.v4.media.session.MediaSessionCompat
import android.support.v4.media.session.PlaybackStateCompat
import android.view.KeyEvent
import androidx.core.app.NotificationCompat
import androidx.core.graphics.drawable.IconCompat
import androidx.media.app.NotificationCompat.MediaStyle
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReadableMap
Expand Down
14 changes: 1 addition & 13 deletions packages/react-native-audio-api/android/src/oldarch/NativeAudioAPIModuleSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,24 +88,12 @@ public NativeAudioAPIModuleSpec(ReactApplicationContext reactContext) {

@ReactMethod
@DoNotStrip
public abstract void registerNotification(String type, String key, Promise promise);

@ReactMethod
@DoNotStrip
public abstract void showNotification(String key, ReadableMap options, Promise promise);

@ReactMethod
@DoNotStrip
public abstract void updateNotification(String key, ReadableMap options, Promise promise);
public abstract void showNotification(String type, String key, ReadableMap options, Promise promise);

@ReactMethod
@DoNotStrip
public abstract void hideNotification(String key, Promise promise);

@ReactMethod
@DoNotStrip
public abstract void unregisterNotification(String key, Promise promise);

@ReactMethod
@DoNotStrip
public abstract void isNotificationActive(String key, Promise promise);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-audio-api/common/cpp/audioapi/core/utils/AudioFileWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace audioapi {
AudioFileWriter::AudioFileWriter(
const std::shared_ptr<AudioEventHandlerRegistry> &audioEventHandlerRegistry,
const std::shared_ptr<AudioFileProperties> &fileProperties)
: audioEventHandlerRegistry_(audioEventHandlerRegistry), fileProperties_(fileProperties) {}
: fileProperties_(fileProperties), audioEventHandlerRegistry_(audioEventHandlerRegistry) {}

void AudioFileWriter::setOnErrorCallback(uint64_t callbackId) {
errorCallbackId_.store(callbackId, std::memory_order_release);
Expand Down