Feat/recording notification #875
Conversation
| Unregister the notification from the system. Must call `register()` again to use. | ||
| | Error type | Description| | ||
| | :--------: | :---------- | | ||
| | `NotSupportedError` | NativeAudioAPIModule is not available | |
There was a problem hiding this comment.
I do not think that we want to add this type of error to this section of docs
| }; | ||
| }, []); | ||
|
|
||
| const setNotification = (paused: boolean) => { |
There was a problem hiding this comment.
is it possible to set icons once and than only change contentText?
There was a problem hiding this comment.
Hmm, we could split the notification setup into config and state options
packages/audiodocs/docs/system/recording-notification-manager.mdx
Outdated
Show resolved
Hide resolved
...eact-native-audio-api/android/src/main/java/com/swmansion/audioapi/core/NativeAudioPlayer.kt
Outdated
Show resolved
Hide resolved
...ct-native-audio-api/android/src/main/java/com/swmansion/audioapi/core/NativeAudioRecorder.kt
Outdated
Show resolved
Hide resolved
...-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/MediaSessionManager.kt
Show resolved
Hide resolved
...-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/MediaSessionManager.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| if (!NativeAudioAPIModule) { | ||
| throw new Error('NativeAudioAPIModule is not available'); |
There was a problem hiding this comment.
it should be sth like AudioAPIError
There was a problem hiding this comment.
shouldn't there all errors that are not directly connected with audio api implementation, be like that then?
f.e. throw new Error('Unsupported input type or failed to decode audio'); in decoder
There was a problem hiding this comment.
we can add some section about that kind of errors to docs
|
|
||
| if (!NativeAudioAPIModule) { | ||
| throw new Error('NativeAudioAPIModule is not available'); | ||
| throw new NotSupportedError('NativeAudioAPIModule is not available'); |
There was a problem hiding this comment.
| throw new NotSupportedError('NativeAudioAPIModule is not available'); | |
| throw new AudioAPIError('NativeAudioAPIModule is not available'); |
packages/react-native-audio-api/src/web-system/notification/RecordingNotificationManager.ts
Show resolved
Hide resolved
michalsek
left a comment
michalsek
left a comment
There was a problem hiding this comment.
Overall looks good, but lets talk a bit what to do about reverts that not necessarily we would like to be reverted. We can create followup tasks if they are not critical to "revert the revertion" later, for important parts it would be best to bring them back before merge'ing
Closes RNAA-397, RNAA-370
Introduced changes
Checklist