Refactor/communication between audio and js threads #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poneciak57
requested changes
Dec 30, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/utils/AudioEventScheduler.h
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/AudioNode.cpp
Outdated
Show resolved
Hide resolved
...t-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferSourceNodeHostObject.h
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/utils/AudioEventScheduler.cpp
Outdated
Show resolved
Hide resolved
mdydek
requested changes
Jan 7, 2026
packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AudioPlayer.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AudioPlayer.cpp
Outdated
Show resolved
Hide resolved
| audioBufferSourceNode->setLoop(value.getBool()); | ||
| auto loop = value.getBool(); | ||
|
|
||
| auto event = [audioBufferSourceNode, loop](BaseAudioContext &context) { |
Contributor
There was a problem hiding this comment.
do we need reference to context here and in all of the lambdas that they do not use context inside it? if not change sfinae definition of a function so more types can be passed in event scheduler
| : nodeManager_(std::make_shared<AudioNodeManager>()), | ||
| : sampleRate_ {sampleRate}, | ||
| nodeManager_(std::make_shared<AudioNodeManager>()), | ||
| audioEventScheduler_(std::make_unique<CrossThreadEventScheduler<BaseAudioContext>>(1024)), |
Contributor
There was a problem hiding this comment.
magic number, put it in some constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
CrossThreadEventSchedulerwrapper to be executed on Audio thread.HostObjectplays aShadowAudioNoderole - it stores a copy of node's state.Read: Simply read
HostObjectstateWrite: Schedule modification and modify
Shadow StateLock free approach!!!
TODO:
Checklist