Add more detailed collection stats #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also uses more consistent terminology and hides the feature gating of metrics behind a single API to make things more manageable.
run-make tests strike again, and this way we don't need put feature gates everywhere we import `bdwgc`.
ltratt
reviewed
Jun 12, 2025
| unsafe fn alloc(&self, layout: Layout) -> *mut u8 { | ||
| #[cfg(feature = "log-stats")] | ||
| GC_COUNTERS.allocated_boxed.fetch_add(1, atomic::Ordering::Relaxed); | ||
| bdwgc::metrics::increment(1, Metric::AllocationsBox); |
Member
There was a problem hiding this comment.
Do we ever call increment with a value other than 1?
Collaborator
Author
There was a problem hiding this comment.
We do on the finalizer thread. It bunches up and returns the number of finalizers that were run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also uses more consistent terminology and hides the feature gating
of metrics behind a single API to make things more manageable.
Sorry, this is a large PR and it was difficult to split this one up any further.