Make libbdwgc a dependency of liballoc instead of libstd #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-hughes
force-pushed
the
move-bdwgc-to-liballoc
branch
from
37a527e to
138003d
Compare
Collaborator
Author
|
Force-pushed a fix to rebase this with the base branch |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
These |
Collaborator
Author
|
Fixed here fc72607 |
Previously, libstd depended on libbdwgc (our bindings layer for libgc.so). Historically this made sense when we tried statically linking libgc.a because the interface was tightly coupled with code in library/std/gc.rs. However, this was always a pain-point: liballoc must also depend on libbdwgc, but libstd depends on liballoc, causing this confusing and error-prone cyclic dependency. This reared its head in two main ways: (1) very slow rustc compile times, because libbdwgc would always cache-bust libstd recompiles; (2) occassionally, the build artefacts would end up in a irreparable state and require a full clean (this mostly happened when sending a SIGINT to `x.py` while it was busy building). This commit fixes both these issues, but it is also a necessary prerequesite for the changes to our stat collection, which require libbdwgc to be isolated from libstd in order to prevent duplicate metric collection.
Building libgc now happens inside the bootstrapper which handles the relevant build args.
Member
|
Please squash. |
jacob-hughes
force-pushed
the
move-bdwgc-to-liballoc
branch
from
fc72607 to
942a788
Compare
Collaborator
Author
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, libstd depended on libbdwgc (our bindings layer for
libgc.so). Historically this made sense when we tried statically linking
libgc.a because the interface was tightly coupled with code in
library/std/gc.rs.
However, this was always a pain-point: liballoc must also depend on
libbdwgc, but libstd depends on liballoc, causing this confusing and
error-prone cyclic dependency. This reared its head in two main ways:
(1) very slow rustc compile times, because libbdwgc would always
cache-bust libstd recompiles; (2) occassionally, the build artefacts
would end up in a irreparable state and require a full clean (this
mostly happened when sending a SIGINT to
x.pywhile it was busybuilding).
This commit fixes both these issues, but it is also a necessary
prerequesite for the changes to our stat collection, which require
libbdwgc to be isolated from libstd in order to prevent duplicate metric
collection.