Automatically generate BDWGC bindings #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
Ah, I see what’s happened here. I’ve not taken into account existing BDWGC artefacts in the build directory. |
Collaborator
Author
|
I've pushed some changes that are needed to land this PR. It mainly revolves around pulling BDWGC out of the library/std build.rs script and into the bootstrapper, this is then reused as a dynamic |
Member
|
Please squash. |
Collaborator
Author
|
These commits are logically separate so I think we can leave as-is |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
Member
|
Please squash. |
Collaborator
Author
|
Squashed |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
I've pushed a fix for this here d25db11. The I'll need to rebase this against ToT if you're happy? |
Member
|
Please squash. |
As part of the bootstrap phase, we now search for `src/bdwgc/include/gc.h` and use that to automatically generate Rust bindings. This is less error-prone and means that we can any BDWGC API we wish without having to manually export them one by one.
This works by ensuring that the bootstrap phase puts libgc.so inside the sysroot, where the librustc-driver and libtest objects are already given to search at load time in their RPATH.
Collaborator
Author
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the bootstrap phase, we now search for
src/bdwgc/include/gc.hand use that to automatically generate Rustbindings. This is less error-prone and means that we can any BDWGC API
we wish without having to manually export them one by one.