Conform timeout errors #319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Apologies for the long delay here! I agree that this is a worthy goal worth pursuing, but after careful consideration, I don't think Finch should be creating and returning Mint errors as I feel that could create more confusion. I think your alternative proposal of encapsulating everything in Finch.Errors is the correct approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conforms the timeout errors in HTTP2 to be the same as HTTP1. I think the errors should in general be encapsulated into just
Finch.Errorthough, and be normalized so we can handle it generic in other libraries. This is already a breaking change, and it'll be much more of a breaking change with switching everything over to a common error but I think it'll make it easier for other libraries to handle common errors.Resolves #318