Skip to content

Change default budget in AADForest to "auto"#317

Merged
matwey merged 2 commits intomasterfrom
aad_budget_auto_default
Jan 21, 2026
Merged

Change default budget in AADForest to "auto"#317
matwey merged 2 commits intomasterfrom
aad_budget_auto_default

Conversation

@matwey
Copy link
Contributor

@matwey matwey commented Jan 21, 2026

This is a follow up to the latest meeting. As was previously discussed, this helps to reduce number of hyper-parameters.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request changes the default value of the budget parameter in the AADForest class from 0.03 to "auto" to reduce the number of hyperparameters users need to configure.

Changes:

  • Updated default budget parameter from 0.03 to "auto" in AADForest.__init__()
  • Updated parameter documentation to reflect the new default value
  • Added explicit budget=0.03 to a regression test

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/coniferest/aadforest.py Changed default budget parameter from 0.03 to "auto" in both the method signature and documentation
tests/test_aadforest.py Added explicit budget=0.03 parameter to test_regression_fit_known

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@matwey matwey force-pushed the aad_budget_auto_default branch from 8c72dcd to 0dcdc6d Compare January 21, 2026 07:44
matwey and others added 2 commits January 21, 2026 08:47
As was previously discussed, this helps to reduce number of hyperparameters.
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

Merging this PR will improve performance by ×18

⚡ 44 improved benchmarks
✅ 3 untouched benchmarks
⏩ 4 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_benchmark_score_samples[2-256-32] 1,398.5 µs 770.4 µs +81.52%
Simulation test_benchmark_fit_known 266.8 ms 117 ms ×2.3
Simulation test_benchmark_feature_signature[2] 563.4 µs 412.7 µs +36.52%
Simulation test_benchmark_fit_sklearn[1024] 5.3 s 4.3 s +22.68%
Simulation test_benchmark_feature_signature[128] 555.7 µs 408.9 µs +35.91%
Simulation test_benchmark_fit_sklearn[128] 668.1 ms 545 ms +22.58%
Simulation test_benchmark_score[1024] 8.5 ms 7 ms +22.04%
Simulation test_benchmark_score_samples[1-128-1024] 9.8 ms 8.3 ms +18.59%
Simulation test_benchmark_score_samples[2-64-1024] 6 ms 4.8 ms +25.16%
Simulation test_benchmark_score_samples[2-256-1] 276.1 µs 157.8 µs +74.96%
Simulation test_benchmark_score_samples[2-64-32] 558.6 µs 294.5 µs +89.72%
Simulation test_benchmark_score_samples[4-128-1048576] 9.7 s 8.8 s +10.79%
Simulation test_benchmark_score_samples[1-256-1024] 18 ms 15 ms +19.88%
Simulation test_benchmark_score_samples[1-128-1048576] 9.7 s 8.3 s +17.57%
Simulation test_benchmark_score_samples[1-256-32] 978.7 µs 771.8 µs +26.8%
Simulation test_benchmark_score_samples[1-256-1048576] 17.9 s 15 s +19.56%
Simulation test_benchmark_score_samples[2-64-1] 223.8 µs 112.2 µs +99.47%
Simulation test_benchmark_score_samples[1-128-1] 264.8 µs 126.6 µs ×2.1
Simulation test_benchmark_score_samples[1-256-1] 276.2 µs 158.3 µs +74.45%
Simulation test_benchmark_score_samples[4-128-1024] 11 ms 8.3 ms +31.92%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing aad_budget_auto_default (5f2082f) with master (c78dece)2

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (a173dc2) during the generation of this report, so c78dece was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@matwey matwey merged commit 8474e24 into master Jan 21, 2026
46 checks passed
@matwey matwey deleted the aad_budget_auto_default branch January 21, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments