-
Notifications
You must be signed in to change notification settings - Fork 51
redesign calibrate task window to mimic search task window #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
redesign calibrate task window to mimic search task window #2612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR restructures the Calibrate Task window UI to align more closely with the Search Task window, improving organization of search-related controls and moving seldom-changed parameters into an “Advanced Options” section.
Changes:
- Replaced the previous nested
Expander/StackPanelstructure for core search parameters with a 2-column grid grouping protease, mass tolerances, missed cleavages, peptide length, dissociation type, and separation type. - Moved file loading parameters, max modification isoforms, variant-related settings, max threads, and minimum score into an
Advanced Optionsexpander, grouped into dedicated sub-sections. - Updated several labels and tooltips for clarity and consistency (e.g., more descriptive explanations for protease, modification limits, and separation type).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2612 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 187 187
Lines 19658 19658
Branches 3636 3636
=======================================
Hits 18621 18621
Misses 566 566
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This pull request refactors and reorganizes the
CalibrateTaskWindow.xamlUI to improve the layout and clarity of the search parameters section. The changes focus on restructuring controls into a more logical grid, enhancing tooltips, and removing redundant or misplaced UI elements. This PR is a prelude to future PRs that will enable calibration with the modern search engine and eventually non-specific peptides.UI layout improvements and reorganization:
ExpanderandStackPanelstructures with a grid-based layout for search parameters, resulting in a cleaner and more organized interface.Removal and relocation of parameters:
Tooltip and labeling enhancements:
Addition of new or reorganized controls: