Skip to content

Conversation

@Alexander-Sol
Copy link
Contributor

This removes the unused SpectralRecovery feature which had failing tests.

Deleted:

  • TaskLayer/MbrAnalysis folder (SpectralRecoveryPSM, SpectralRecoveryResults, SpectralRecoveryRunner)
  • EngineLayer/ClassicSearch/MiniClassicSearchEngine.cs
  • Test/SpectralRecoveryTest.cs and test data

Removed DoSpectralRecovery parameter and related UI from SearchTaskWindow, MainWindow settings, GuiGlobalParams, and UpdateGUISettings.

This removes the unused SpectralRecovery feature which had failing tests.

Deleted:
- TaskLayer/MbrAnalysis folder (SpectralRecoveryPSM, SpectralRecoveryResults, SpectralRecoveryRunner)
- EngineLayer/ClassicSearch/MiniClassicSearchEngine.cs
- Test/SpectralRecoveryTest.cs and test data

Removed DoSpectralRecovery parameter and related UI from SearchTaskWindow,
MainWindow settings, GuiGlobalParams, and UpdateGUISettings.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.72%. Comparing base (e7a072c) to head (921e06c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2605      +/-   ##
==========================================
- Coverage   94.72%   94.72%   -0.01%     
==========================================
  Files         191      187       -4     
  Lines       20008    19651     -357     
  Branches     3701     3635      -66     
==========================================
- Hits        18953    18614     -339     
+ Misses        579      566      -13     
+ Partials      476      471       -5     
Flag Coverage Δ
unittests 94.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...heus/EngineLayer/Util/ScanWithIndexAndNotchInfo.cs 100.00% <ø> (ø)
MetaMorpheus/GuiFunctions/GuiGlobalParams.cs 100.00% <ø> (ø)
...aMorpheus/GuiFunctions/GuiGlobalParamsViewModel.cs 98.01% <ø> (-0.08%) ⬇️
...yer/GlycoSearchTask/PostGlycoSearchAnalysisTask.cs 91.18% <ø> (ø)
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 90.69% <100.00%> (-0.30%) ⬇️
...aMorpheus/TaskLayer/SearchTask/SearchParameters.cs 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nbollis
nbollis previously approved these changes Jan 15, 2026
trishorts
trishorts previously approved these changes Jan 15, 2026
zhuoxinshi
zhuoxinshi previously approved these changes Jan 22, 2026
Alexander-Sol and others added 2 commits January 22, 2026 13:38
This removes the unused SpectralRecovery feature which had failing tests.

Deleted:
- TaskLayer/MbrAnalysis folder (SpectralRecoveryPSM, SpectralRecoveryResults, SpectralRecoveryRunner)
- EngineLayer/ClassicSearch/MiniClassicSearchEngine.cs
- Test/SpectralRecoveryTest.cs and test data

Removed DoSpectralRecovery parameter and related UI from SearchTaskWindow,
MainWindow settings, GuiGlobalParams, and UpdateGUISettings.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@Alexander-Sol Alexander-Sol dismissed stale reviews from zhuoxinshi, trishorts, and nbollis via 2f93da6 January 22, 2026 19:38
zhuoxinshi
zhuoxinshi previously approved these changes Jan 22, 2026
@Alexander-Sol Alexander-Sol dismissed zhuoxinshi’s stale review January 22, 2026 19:44

The merge-base changed after approval.

trishorts
trishorts previously approved these changes Jan 22, 2026
@Alexander-Sol Alexander-Sol dismissed trishorts’s stale review January 22, 2026 19:58

The merge-base changed after approval.

trishorts
trishorts previously approved these changes Jan 22, 2026
@Alexander-Sol Alexander-Sol dismissed trishorts’s stale review January 22, 2026 20:12

The merge-base changed after approval.

nbollis
nbollis previously approved these changes Jan 22, 2026
trishorts
trishorts previously approved these changes Jan 23, 2026
zhuoxinshi
zhuoxinshi previously approved these changes Jan 23, 2026
@Alexander-Sol Alexander-Sol dismissed stale reviews from zhuoxinshi, trishorts, and nbollis via 921e06c January 23, 2026 20:32
@trishorts trishorts merged commit 4465df8 into smith-chem-wisc:master Jan 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants