-
Notifications
You must be signed in to change notification settings - Fork 51
Remove SpectralRecovery/MbrAnalysis feature #2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
trishorts
merged 6 commits into
smith-chem-wisc:master
from
Alexander-Sol:DeleteSpectralRecovery
Jan 23, 2026
Merged
Remove SpectralRecovery/MbrAnalysis feature #2605
trishorts
merged 6 commits into
smith-chem-wisc:master
from
Alexander-Sol:DeleteSpectralRecovery
Jan 23, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the unused SpectralRecovery feature which had failing tests. Deleted: - TaskLayer/MbrAnalysis folder (SpectralRecoveryPSM, SpectralRecoveryResults, SpectralRecoveryRunner) - EngineLayer/ClassicSearch/MiniClassicSearchEngine.cs - Test/SpectralRecoveryTest.cs and test data Removed DoSpectralRecovery parameter and related UI from SearchTaskWindow, MainWindow settings, GuiGlobalParams, and UpdateGUISettings. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2605 +/- ##
==========================================
- Coverage 94.72% 94.72% -0.01%
==========================================
Files 191 187 -4
Lines 20008 19651 -357
Branches 3701 3635 -66
==========================================
- Hits 18953 18614 -339
+ Misses 579 566 -13
+ Partials 476 471 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nbollis
previously approved these changes
Jan 15, 2026
trishorts
previously approved these changes
Jan 15, 2026
zhuoxinshi
previously approved these changes
Jan 22, 2026
This removes the unused SpectralRecovery feature which had failing tests. Deleted: - TaskLayer/MbrAnalysis folder (SpectralRecoveryPSM, SpectralRecoveryResults, SpectralRecoveryRunner) - EngineLayer/ClassicSearch/MiniClassicSearchEngine.cs - Test/SpectralRecoveryTest.cs and test data Removed DoSpectralRecovery parameter and related UI from SearchTaskWindow, MainWindow settings, GuiGlobalParams, and UpdateGUISettings. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…-Sol/MetaMorpheus into DeleteSpectralRecovery
2f93da6
zhuoxinshi
previously approved these changes
Jan 22, 2026
The merge-base changed after approval.
trishorts
previously approved these changes
Jan 22, 2026
The merge-base changed after approval.
trishorts
previously approved these changes
Jan 22, 2026
The merge-base changed after approval.
nbollis
previously approved these changes
Jan 22, 2026
trishorts
previously approved these changes
Jan 23, 2026
zhuoxinshi
previously approved these changes
Jan 23, 2026
…-Sol/MetaMorpheus into DeleteSpectralRecovery
921e06c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unused SpectralRecovery feature which had failing tests.
Deleted:
Removed DoSpectralRecovery parameter and related UI from SearchTaskWindow, MainWindow settings, GuiGlobalParams, and UpdateGUISettings.