Disable error for property with #[Override] attribute #1823
+53
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmuffme
force-pushed
the
handle-override-public-properties
branch
from
0888f7c to
8662d2f
Compare
kkmuffme
force-pushed
the
handle-override-public-properties
branch
from
2eb49b3 to
6273e9b
Compare
Contributor
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.5 #[Override] can also be used on properties.
Fix false positive errors for:
SlevomatCodingStandard.Classes.ForbiddenPublicProperty.ForbiddenPublicProperty
SlevomatCodingStandard.TypeHints.PropertyTypeHint
This has already been fixed for SlevomatCodingStandard.TypeHints.ParameterTypeHint in cda88e6
Fix #1745 instead of with a new option by using the native attribute instead now, as this is more flexible and specific.