Merged
Conversation
robnagler
requested changes
Sep 9, 2025
Collaborator
robnagler
left a comment
robnagler
left a comment
There was a problem hiding this comment.
I made all these comments so I'm sending them. After this, I'm going to commit my changes to this branch, and I'll need you to get it working. There should be a test.
- package_path supported properly for sliclets - ctx only supports a single (fconf) yaml file
robnagler
requested changes
Sep 16, 2025
| import h5py | ||
|
|
||
| i = _imageset() | ||
| with pkio.save_chdir(pkunit.work_dir()) as w: |
Collaborator
There was a problem hiding this comment.
save_chdir_work() which empties the directory first
|
|
||
|
|
||
| def test_imageset_save_to_file(): | ||
| from glob import glob |
Collaborator
There was a problem hiding this comment.
generally we just import glob, which is the module, but since you already import pkio. just use pkoio.sorted_glob
| :license: http://www.apache.org/licenses/LICENSE-2.0.html | ||
| """ | ||
|
|
||
| from pykern import pkunit |
Collaborator
There was a problem hiding this comment.
generally we don't import it here just out of formality so that all tests defer imports, which can be very important.
| [3, 5, 7.5, 3], | ||
| ) | ||
| pkunit.pkeq(round(f.x.fit.results.sig, 2), 0.53) | ||
| pkunit.pkeq([round(v, 2) for v in f.x.fit.fit_line], [0.5, 2.5, 12.5, 2.5, 0.5]) |
Collaborator
There was a problem hiding this comment.
this probably should be returned in i
robnagler
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to add some test cases, but this is ready for a draft review.