Replace Old device.screen; Add Target Controls#152
Merged
Conversation
…n.move_target to move the target. Fixed Bug Where upstream_status Would Never Fire With No Upstream Devices.
robnagler
changed the title
Collaborator
Author
|
Having a problem in screen2_test.py where TGT_STS is connecting to the monitor but not sending its value afterwards. The result is screen is uninitialized and breaks the test. Not sure what changed between this version and the last one. |
Collaborator
Author
|
Had a good talk with Paul and worked it out. New path through the state machine will fire |
robnagler
requested changes
Oct 1, 2025
Collaborator
robnagler
left a comment
robnagler
left a comment
There was a problem hiding this comment.
Just saw this and wanted to give a comment
robnagler
requested changes
Oct 8, 2025
- removed special DEV_CAMERA code in device/__init__.py - updated epics sim-detector to simulate add/remove target - added DEV_CAMERA2 for example camera which has no targets
moellep
approved these changes
Oct 9, 2025
robnagler
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the sliclet with a new event based slicops.device.screen. It also adds target controls and upstream controls to the API and UI.