Geometry-Aware Fitting, Peak-Window Analysis, and Direct HDF5 Results Output#358
Open
kabanaty wants to merge 17 commits intoslaclab:mainfrom
Open
Geometry-Aware Fitting, Peak-Window Analysis, and Direct HDF5 Results Output#358kabanaty wants to merge 17 commits intoslaclab:mainfrom
kabanaty wants to merge 17 commits intoslaclab:mainfrom
Conversation
…e fitting method. Added conversion from stage to beam coordinate systems.
Merge upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves wire scan analysis robustness by refining how results are fit, stored, and interpreted. The main focus is making analysis geometry-aware, reducing fit contamination, and enabling direct saving of results in a modern, portable format.
Major Changes
.h5eliminating intermediate conversions and making Python the source of record.Minor Changes & Fixes