Skip to content

Geometry-Aware Fitting, Peak-Window Analysis, and Direct HDF5 Results Output#358

Open
kabanaty wants to merge 17 commits intoslaclab:mainfrom
kabanaty:main
Open

Geometry-Aware Fitting, Peak-Window Analysis, and Direct HDF5 Results Output#358
kabanaty wants to merge 17 commits intoslaclab:mainfrom
kabanaty:main

Conversation

@kabanaty
Copy link
Collaborator

@kabanaty kabanaty commented Feb 5, 2026

This PR improves wire scan analysis robustness by refining how results are fit, stored, and interpreted. The main focus is making analysis geometry-aware, reducing fit contamination, and enabling direct saving of results in a modern, portable format.

Major Changes

  • Direct HDF5 output from results objects
    • Results can now be saved directly to .h5 eliminating intermediate conversions and making Python the source of record.
  • Geometry-aware position fitting
    • Positional fits now account for wire hardware geometry, ensuring beam position and size are reported in physically correct beam coordinates
  • Peak-window only fitting
    • Fits are restricted to a selected peak window, avoiding background tails and improving stability and repeatability of fit parameters.

Minor Changes & Fixes

  • Added a buffer reservation helper to centralize buffer acquisition logic
  • Enforced monotonic profile index masks to be strictly boolean (fixes subtle indexing bugs)
  • Added a wire speed setter to wire device interfaces
  • Miscellaneous bug fixes, cleanup, and small consistency improvements discovered during testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant