Open
Conversation
eloise-nebula
requested changes
Dec 9, 2025
Collaborator
eloise-nebula
left a comment
eloise-nebula
left a comment
There was a problem hiding this comment.
Hi Shamin, the polling loop looks good, I'd just like to communicate the error status through the callback somehow.
kabanaty
reviewed
Dec 12, 2025
kabanaty
reviewed
Dec 12, 2025
- Put sleep in magnet scan polling loop - Fix string in MagnetTimeoutError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current Magnet scan method does not wait for the BACT to settle to the BDES value. This PR adds a BDES setter method for scans that does this.