Quad Scan Emittance subclass and refactor#338
Draft
shamin-slac wants to merge 22 commits intoslaclab:mainfrom
Draft
Quad Scan Emittance subclass and refactor#338shamin-slac wants to merge 22 commits intoslaclab:mainfrom
shamin-slac wants to merge 22 commits intoslaclab:mainfrom
Conversation
- Add wire_lblms.yaml - Modify rms_sizes and centroids from screen beam profile measurement to be units of microns
…from emittance.py - Modify docstrings and comments
- Separate handling of getting rmats from meme for wire scanners
- Rewrite EmittanceMeasurementBase
- Add construct_result method
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the QuadScanEmittance class so that it subclasses from EmittanceMeasurementBase. This allows for a lot of emittance code to be reused and cleans up very quad scan specific code.