[gather_columns] Traversing function calls#14
Open
john-bodley wants to merge 1 commit intoslaclab:masterfrom
Open
[gather_columns] Traversing function calls#14john-bodley wants to merge 1 commit intoslaclab:masterfrom
john-bodley wants to merge 1 commit intoslaclab:masterfrom
Conversation
6f1ce7f to
b22815a
Compare
b22815a to
90062f6
Compare
Member
|
I'm happy to merge this as-is, but for the purposes of limited scope on this example, what do you think of checking the function call name to see that it's in one of pre-defined ones in SQL, e.g.: |
Author
|
@brianv0 I'm happy to augment the PR to include a whitelist of function names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR augments the
print_column_resolution_ordermethod to also examine columns which are function calls, so queries of the formassociate the column
foowith tablea, i.e., produces the output,Note that the
column_namevariable was unused and thus I deleted it.