This repository was archived by the owner on Jan 31, 2025. It is now read-only.
fix: patch CheckTx handler for MEVCheckTxHandler#592
Closed
crnbarr93 wants to merge 2 commits intoskip-mev:release/v2.x.xfrom
Closed
fix: patch CheckTx handler for MEVCheckTxHandler#592crnbarr93 wants to merge 2 commits intoskip-mev:release/v2.x.xfrom
crnbarr93 wants to merge 2 commits intoskip-mev:release/v2.x.xfrom
Conversation
fix: err var assignment
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v2.x.x #592 +/- ##
=================================================
Coverage ? 45.40%
=================================================
Files ? 62
Lines ? 3625
Branches ? 0
=================================================
Hits ? 1646
Misses ? 1841
Partials ? 138 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix an issue with the
CheckTxfunction in theMEVCheckTxHandlerstruct. In the recovery handler for the function the error log was being assigned toerrbefore being returned as an actual error value rather than a request response as expected.This was causing the
CListMempoolhandler forCheckTxin CometBFT to panic here, which when called fromReactorvia a gossiped transaction would cause the entire node to panic.This produced the following panic as an example: