Version 1.0.77 #1512
Merged
Version 1.0.77 #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced on 1.0.76 where TemplateLiteral normalization during Value processing would result in a StackOverflow when decoding a infinite TemplateLiteral pattern back into a TemplateLiteral.
The underlying problem is that in order to retain information about a TemplateLiteral having an infinite expansion (meaningful to the type system), that information MUST be encoded as a TemplateLiteral, but where the expectation from Value is that a decoded infinite TemplateLiteral pattern "should" return a terminating type (which would be TString)
This is a slight mismatch, so this PR introduces a TemplateLiteralDecodeUnsafe which may map TemplateLiteral -> TemplateLiteral (Identity) if the pattern is infinite. Will need to review this in later revisions.
Fixes #1510