Remove unused psycopg2.extensions.quote_ident import #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This import was never used in the codebase and prevents the package from working with psycopg3, which is now the recommended PostgreSQL adapter for Django. Fixes simonw#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused
from psycopg2.extensions import quote_identimport fromviews.py.This import was never used anywhere in the codebase (grep confirms it only appears on line 22 as the import statement), but it prevents the package from working with psycopg3, which is now the recommended PostgreSQL adapter for Django (since Django 4.2).
Test plan
quote_identis not used anywhere in the codebaseFixes #162