Gloas consensus logic for attestations#8760
Open
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Open
Gloas consensus logic for attestations#8760michaelsproul wants to merge 1 commit intosigp:unstablefrom
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Conversation
jimmygchen
approved these changes
Feb 9, 2026
Member
jimmygchen
left a comment
There was a problem hiding this comment.
This looks great, I've got nothing to add. Let's merge 👍
Merge Queue Status🟠 Waiting for merge conditions (rule: Entered the queue at: Required conditions to merge
Required conditions to stay in the queue
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update attestation consensus logic for the Gloas fork.
This covers
get_attestation_participation_flag_indicesandprocess_attestationat the spec level. Inside LH we have splitprocess_attestationinto several parts for use in different places, so we update those component functions:verify_attestation_for_statecovers the new check on the attestation dataindex. This function is called fromverify_attestation_for_block_inclusionwhich is otherwise the same (no other changes in Gloas compared to Electra).process_attestation{s}is added covering the Gloas case. It would have been possible to abstract the existing Electra logic, but with this logic already being quite gnarly I can see the case for a separate function (this is how Shane had it set up on his branch). I've made some tweaks so that it follows the flow of the spec , although there are few places where differences are required due to Rust's ownership/borrowing.Many credits to @shane-moore for writing this logic. I just adapted and reviewed it.
Additional Info
All EF tests for attestations are passing 🎉