Support pinning nightly ef test runs#8738
Open
jimmygchen wants to merge 3 commits intosigp:unstablefrom
Open
Conversation
jimmygchen
added
test improvement
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for pinning a specific nightly ef test run by using
nightly-<run_id>format (e.g.,CONSENSUS_SPECS_TEST_VERSION=nightly-21575883288). This allows CI and local testing to reproduce results from a specific consensus-specs workflow run rather than always fetching the latest.Also fixes the workflow branch from
devtomasterand adds--failflags to curl commands for better error handling.Additional Info
Usage:
CONSENSUS_SPECS_TEST_VERSION=nightly make- fetches latest nightlyCONSENSUS_SPECS_TEST_VERSION=nightly-21575883288 make- fetches specific run