Never use MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS for networks that started with Fulu enabled#8731
Open
dknopik wants to merge 1 commit intosigp:unstablefrom
Open
Never use MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS for networks that started with Fulu enabled#8731dknopik wants to merge 1 commit intosigp:unstablefrom
dknopik wants to merge 1 commit intosigp:unstablefrom
Conversation
…hat started with Fulu enabled
dknopik
added
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Lighthouse uses
MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTSfor blob and column retention instead ofMIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTSif Fulu activated less thanMIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTSepochs ago - also if Fulu activated at genesis. This causes unexpected behaviour, as there are no blob sidecars to be stored or requested in such networks.Proposed Changes
Add a special case to avoid that logic in post-Fulu genesis networks (
fulu_fork_epoch == 0)