Add CI job to check for deleted files#8727
Open
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Open
Add CI job to check for deleted files#8727michaelsproul wants to merge 1 commit intosigp:unstablefrom
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Conversation
Member
Author
|
Expecting this to fail (due to OTB) until Lion's PR is merged. |
|
Some required checks have failed. Could you please take a look @michaelsproul? 🙏 |
mergify
bot
added
waiting-on-author
Collaborator
|
Will we remember to add new deleted files in this list? |
Member
Author
|
I will 😁 |
Member
Author
|
At least it's easier than remembering to check every PR for random files coming back from the dead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a job to CI that checks for deleted files which have accidentally been re-added. It seems that every time we delete a major component, it inevitably gets brought back from the dead by a merge conflict.
e.g.
The OTB verification service was deleted here:
Then re-added here:
Then re-deleted here:
The same thing happened with
PartialBeaconStaterecently too.Additional Info
Adding to
.gitignoreisn't strong enough, asgitwill still try to resolve conflicts for files that are on one branch and ignored on the other.