Skip to content

Record metrics for only valid gossip blocks#8723

Open
pawanjay176 wants to merge 3 commits intosigp:unstablefrom
pawanjay176:fix-cache-write
Open

Record metrics for only valid gossip blocks#8723
pawanjay176 wants to merge 3 commits intosigp:unstablefrom
pawanjay176:fix-cache-write

Conversation

@pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Fixes the issue where we were setting block observed timings for blocks that were potentially gossip invalid.
Thanks @gitToki for the find

@pawanjay176 pawanjay176 requested a review from jxs as a code owner January 29, 2026 20:58
@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Jan 29, 2026
@pawanjay176 pawanjay176 added the low-hanging-fruit Easy to resolve, get it before someone else does! label Feb 6, 2026
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 8, 2026
@mergify mergify bot added the queued label Feb 8, 2026
@mergify
Copy link

mergify bot commented Feb 8, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at c233bb1

This pull request spent 24 minutes 44 seconds in the queue, including 22 minutes 51 seconds running CI.
The checks were run on draft #8769.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Feb 8, 2026
@mergify mergify bot added dequeued and removed queued labels Feb 8, 2026
@michaelsproul
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Feb 8, 2026

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link

mergify bot commented Feb 8, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at c233bb1

This pull request spent 24 minutes 5 seconds in the queue, including 22 minutes 46 seconds running CI.
The checks were run on draft #8770.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added queued and removed dequeued labels Feb 8, 2026
mergify bot added a commit that referenced this pull request Feb 8, 2026
@mergify mergify bot added dequeued and removed queued labels Feb 9, 2026
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Feb 9, 2026
@mergify mergify bot removed the dequeued label Feb 9, 2026
@michaelsproul michaelsproul added blocked and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 9, 2026
@michaelsproul
Copy link
Member

Blocked on:

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed blocked labels Feb 9, 2026
@mergify mergify bot added the queued label Feb 9, 2026
@mergify
Copy link

mergify bot commented Feb 9, 2026

Merge Queue Status

🟠 Waiting for merge conditions (rule: default)

Entered the queue at: 2026-02-09 04:51 UTC.
Checks are running on draft #8773 (dashboard).
Merge ETA: 2026-02-09 05:23 UTC. Buckle up 🚀

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success
Required conditions to stay in the queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue default]:
      • #approved-reviews-by >= 1
      • check-success=license/cla
      • check-success=target-branch-check
      • label!=do-not-merge

mergify bot added a commit that referenced this pull request Feb 9, 2026
mergify bot added a commit that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low-hanging-fruit Easy to resolve, get it before someone else does! queued ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants