Disable legacy-arith by default in consensus/types#8695
Open
macladson wants to merge 5 commits intosigp:unstablefrom
Open
Disable legacy-arith by default in consensus/types#8695macladson wants to merge 5 commits intosigp:unstablefrom
legacy-arith by default in consensus/types#8695macladson wants to merge 5 commits intosigp:unstablefrom
Conversation
pawanjay176
approved these changes
Jan 22, 2026
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
This LGTM, but it would be good if someone else can also take a look
| .saturating_sub(1u64); | ||
|
|
||
| if reqd_randao_epoch < state.min_randao_epoch() || epoch > state.current_epoch() + 1 { | ||
| if reqd_randao_epoch < state.min_randao_epoch() |
Member
There was a problem hiding this comment.
Should also remove the allow lint in this file
Member
Author
There was a problem hiding this comment.
There are still some more #[allow(clippy::arithmetic_side_effects)] in beacon_state.rs and in validator.rs. Those seem a bit more involved to remove so I have left them for now
|
This pull request has merge conflicts. Could you please resolve them @macladson? 🙏 |
mergify
bot
added
waiting-on-author
macladson
added
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Currently,
consensus/typescannot build withno-default-featuressince we use "legacy" standard arithmetic operations.Proposed Changes
legacy-arithtosaturating-arithand disable it by default.Additional Info
We could consider removing support for standard arithmetic entirely, although I think having an opt-in feature which makes the dangers of enabling it clear is an okay solution for now, and won't break any external users (and our own
state_processingcrate).Incidentally, the ergonomics around using explicit methods such as
saturating_addwith integer types (which is available even withoutsaturating-arith) is a bit awkward, since it requires casting to u64 first.