Open
Conversation
shane-moore
reviewed
Jan 19, 2026
| let builder = state.get_validator(builder_index as usize)?; | ||
|
|
||
| // For self-builds, amount must be zero regardless of withdrawal credential prefix | ||
| if builder_index == block.proposer_index() { |
Member
There was a problem hiding this comment.
this self-building check has been updated to if builder_index == BUILDER_INDEX_SELF_BUILD
https://ethereum.github.io/consensus-specs/specs/gloas/beacon-chain/#new-process_execution_payload_bid
additionally, looks like a few more mods have happened to this function in the spec as well since we've made the in-protocol builder a new staked actor
all the beacon chain spec page's implementations we've made supported up til v1.6.1, so probably good idea to go through the spec PR's from then til v1.7.0-alpha.1 as to be sure we're compliant
Member
Author
There was a problem hiding this comment.
yeah we are working through this now, planning to go through every function
michaelsproul
added
the
consensus
- Fix DOMAIN_BEACON_BUILDER value (0x1B -> 0x0B per spec) - Add DOMAIN_PROPOSER_PREFERENCES (0x0D) - Add min_builder_withdrawability_delay config (4096 epochs) - Add MaxBuildersPerWithdrawalsSweep to EthSpec trait - Add gloas_only/gloas_and_later handlers for EF tests - Add SSZ static tests for all new Gloas types
- Add fork choice constants to consts.rs (PayloadStatus, timeliness indices) - Add payload_timely_threshold() helper to EthSpec - Exclude Gloas from fork_choice tests until implementation is complete - Add PayloadAttestation operation test handler for EF tests
* Added gloas exclusion to `FinalityHandler` * Fix Gloas EF test failures and add test exclusions - Fix execution_payload_availability initialization in fork upgrade to set all bits to true per spec (was all zeros) - Fix minimal spec gloas_fork_version: [0x07,0x00,0x00,0x01] (was 0x00) - Fix payload attestation signature domain to use get_domain instead of compute_domain with genesis fork version - Add proposer slashing handler to clear builder_pending_payment per EIP-7732 spec - Add Gloas test exclusions for unimplemented functionality: - sanity_blocks, sanity_slots, random, transition, finality handlers - deposit_request operation (requires builder deposit functionality) - Python exclusions for check_all_files_accessed.py * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR breaks out the consensus changes from:
And merges in:
The goal is to get up to date with the latest spec (v1.7.0-alpha.1) and get the EF tests passing. We do not need the
BeaconChainenvelope processing changes for this, so they will stay in #8279.