Open
Conversation
* lean init * container functions implemented * using lh context * changes * clean up * linting * changes * clean up
* minor changes * changes * changes * forkchoice * remove ds_store
hopinheimer
added
the
lean
jxs
reviewed
Jan 6, 2026
Comment on lines
+163
to
+165
| /// Extracts the libp2p PeerId from an ENR's public key | ||
| /// This matches the implementation in network_utils::enr_ext::EnrExt::peer_id | ||
| fn extract_peer_id_from_enr(enr: &enr::Enr<enr::CombinedKey>) -> Result<PeerId, String> { |
Member
There was a problem hiding this comment.
can't we just use that instead then?
| /// | ||
| /// # Returns | ||
| /// A vector of raw ENR string bytes. Invalid entries are skipped with warnings. | ||
| pub fn load_bootstrap_nodes<P: AsRef<Path>>(path: P) -> Result<Vec<String>, String> { |
Member
There was a problem hiding this comment.
can we use proper error types instead of String?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Lean Consensus spec . Currently client is spec compliant with the devnet-1 for the PQ interop.
docker build . -t lighthouse:local