SG-39031 removed for outdated reference #1079
Open
+7
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-villavicencio-adsk
approved these changes
Jan 6, 2026
julien-lang
requested changes
Jan 7, 2026
Member
julien-lang
left a comment
julien-lang
left a comment
There was a problem hiding this comment.
Please do not break retro-compatibility with current TK component versions that would use this "future" tk-core version and would break because the setCodecForCStrings method would no longer exist.
We can always add a deprecation warning when this is used and create a follow up ticket to handle long term compatibility break.
julien-lang
reviewed
Jan 8, 2026
julien-lang
reviewed
Jan 8, 2026
julien-lang
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes legacy Qt4-specific code and updates PySide2 compatibility, simplifying the codebase and improving maintainability. The main changes involve eliminating conditional logic for Qt4 and updating method signatures to match current PySide2/Qt5 APIs.
Qt4-specific code removal:
show()andmoveToThread()that were only needed for Qt4 compatibility inlogin_dialog.pyandasync_bootstrap.py. This reduces complexity and prevents issues in Qt5/PySide2 environments. [1] [2]PySide2/Qt5 API updates:
translatemethod inpyside2_patcher.pyto remove the deprecatedencodingargument, ensuring compatibility with PySide2/Qt5 and aligning with the latest API expectations.