Fix CI issues #18
Merged
Fix CI issues #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of `sysinfo` we are planning to use requires MSRV 1.74.0
`macos-10.15` and `ubuntu-18.04` are no longer available
This was referenced Dec 30, 2024
unlimitedsola
force-pushed
the
ci-fix
branch
from
f46bf67 to
b36dd4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various CI issues for my other PR #17.
Changes
Updated Runner Images
GitHub Action no longer offers
macos-10.15andubuntu-18.04images. Jobs that depend on these images are no longer schedulable. This PR updates the runner images to what's currently available according to this documentation.Bump MSRV to 1.74.0
I ran into this strange issue when trying to build the current master with Rust 1.43, but not for the current stable version.
The version 1.74 is chosen to pave the path for #17 as the
sysinfocrate we are replacing with requires MSRV 1.74Resolve Clippy Warnings
The bumped MSRV also comes with newer lints/warnings, this PR also includes the fixes suggested by Clippy to make CI pass.
Lints fixed:
Here is a successful action run from my forked repo with changes in this PR: https://github.com/sola-contrib/bugreport/actions/runs/12552120598