Icons now stay the same size if the map zooms in/out #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Screen size of all map icons now remains constant regardless of how zoomed in or out the world map is.
- Cut out the part of UpdateNode that handles the resizing and moved it into a dedicated function. - OnMapScaleChanged now just resizes existing nodes instead of rebuilding all nodes from scratch, which runs a lot faster when there are lots of nodes visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all pfQuest icons on the world map keep the same screen size when zooming the map in/out using other addons, such as Magnify.
I've only tested this on wotlk 3.3.5, if anyone can test it on vanilla/tbc that'd be great.
I don't think I did anything too fancy so I expect it should work.