Misc CoopMat/lambda expr fixes. #9685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
kaizhangNV
approved these changes
Jan 22, 2026
Contributor
kaizhangNV
left a comment
kaizhangNV
left a comment
There was a problem hiding this comment.
LGTM.
Just one suggestion, hopefully we can make the flash attention tests as a verifiable executable test, instead of just a compile test.
| should only perform uniform operations for portability. If your code specifies a combination | ||
| that is not supported by the device, the behavior is undefined. | ||
|
|
||
| Additionally, while only `MemoryScope.Subgroup` (warp-level cooperation) is supported on CUDA, |
Contributor
There was a problem hiding this comment.
Looks like we can also support this on cuda as well.
Merged
via the queue into
shader-slang:master
with commit Jan 22, 2026
849a5d1
65 of 67 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.