Fix RenderDoc F11 step-into failure for cross-module Slang functions #9650
+110
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions defined in files included via __include were missing DebugFunctionDefinition in SPIRV debug output. This was because included source files were not being added to the translation unit's source file list, which is used during debug info generation. The fix adds included source files to the translation unit by calling addIncludedSourceFileIfNotExist when processing __include directives.
FrostyLeaves
changed the title
csyonghe
approved these changes
Jan 23, 2026
Collaborator
|
Changes are clean and looks good to me. Thank you for contributing! |
jkwak-work
reviewed
Jan 30, 2026
Comment on lines
+1876
to
+1880
| // Add to translation unit's source files for debug info generation | ||
| if (translationUnit) | ||
| { | ||
| translationUnit->addIncludedSourceFileIfNotExist(sourceFile); | ||
| } |
Collaborator
There was a problem hiding this comment.
@FrostyLeaves , can you explain why these lines are needed.
This appears to be causing CI failure on slangpy repo.
I am going to revert it for now to resolve the CI failure.
#9791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions defined in files included via __include were missing DebugFunctionDefinition in SPIRV debug output. This was because included source files were not being added to the translation unit's source file list, which is used during debug info generation.
The fix adds included source files to the translation unit by calling addIncludedSourceFileIfNotExist when processing __include directives.