update to use non deprecated pluginlib macro#2
Closed
mikaelarguedas wants to merge 1 commit intosevenbitbyte:indigofrom
Closed
update to use non deprecated pluginlib macro#2mikaelarguedas wants to merge 1 commit intosevenbitbyte:indigofrom
mikaelarguedas wants to merge 1 commit intosevenbitbyte:indigofrom
Conversation
Author
|
Any rationale for closing this instead of merging it ? |
Owner
|
The nodelet is only a skeleton presently and does nothing useful so we'll just drop all nodelet support as I don't think its an important feature. https://github.com/sevenbitbyte/ros_openlighting/blob/master/ola_ros/src/ola_bridge_nodelet.cpp Follow this PR #3 for updates, I'm currently reviewing kinetic support due to some HW dependencies forcing Ubuntu 16.04. Will review soon for more modern rosdistros. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These macros, deprecated for now 8 years, will be removed in the next ROS release (ROS Melodic)
This change will allow the code to keep compiling on future ROS versions