fix outdated docs for ParseError#1074
Merged
Manishearth merged 1 commit intoservo:mainfrom Sep 8, 2025
whispersofthedawn:parseerror-docs
Merged
fix outdated docs for ParseError#1074Manishearth merged 1 commit intoservo:mainfrom whispersofthedawn:parseerror-docs
Manishearth merged 1 commit intoservo:mainfrom
whispersofthedawn:parseerror-docs
Conversation
The referenced unused variant seems to have been removed in commit 52d736e with the move to `#[non_exhaustive]`.
Manishearth
approved these changes
Sep 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
=======================================
Coverage ? 82.56%
=======================================
Files ? 24
Lines ? 4244
Branches ? 0
=======================================
Hits ? 3504
Misses ? 740
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Hi! I see that there's some sort of test failure to do with sanitizers, but I don't think that has anything to do the changes in this PR. I can't imagine why this error (repeated several times) would be related to this trivial docs change: error: mixing `-Zsanitizer` will cause an ABI mismatch in crate `data_url`
|
= help: the `-Zsanitizer` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely
= note: unset `-Zsanitizer` in this crate is incompatible with `-Zsanitizer=thread` in dependency `core`
= help: set `-Zsanitizer=thread` in this crate or unset `-Zsanitizer` in `core`
= help: if you are sure this will not cause problems, you may use `-Cunsafe-allow-abi-mismatch=sanitizer` to silence this errorGiven that this is a nightly-only error, I assume this is an issue with CI configuration? I suspect it's appearing now as a result of rust-lang/rust#138736. |
Member
|
Yes. I don't recall if that test blocks the merge queue, but we may need to fix it before being able to land this. |
takumi-earth
pushed a commit
to earthlings-dev/rust-url
that referenced
this pull request
Jan 27, 2026
The referenced unused variant seems to have been removed in commit 52d736e with the move to `#[non_exhaustive]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The referenced unused variant seems to have been removed in commit 52d736e with the move to
#[non_exhaustive].