Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eventhandler.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
'labeled': 'on_issue_labeled',
'enqueued': 'on_pr_enqueued',
'dequeued': 'on_pr_dequeued',
'ready_for_review': 'on_pr_ready_for_review',
}


Expand All @@ -36,6 +37,9 @@ def on_pr_enqueued(self, api, payload):
def on_pr_dequeued(self, api, payload):
pass

def on_pr_ready_for_review(self, api, payload):
pass

def on_issue_labeled(self, api, payload):
pass

Expand Down
6 changes: 6 additions & 0 deletions handlers/status_update/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ def on_pr_updated(self, api, payload):
update_rebase_status(api, payload)
handle_custom_labels(api, 'updated')

def on_pr_ready_for_review(self, api, payload):
clear_pr_labels(api)
api.add_label(AWAITING_REVIEW)
update_rebase_status(api, payload)
handle_custom_labels(api, 'ready')

def on_pr_closed(self, api, payload):
handle_custom_labels(api, 'closed')
if "pull_request" in payload and \
Expand Down
23 changes: 23 additions & 0 deletions handlers/status_update/tests/pr_ready_for_review.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"expected": {
"labels": [
"S-awaiting-review"
]
},
"initial": {},
"payload": {
"number": 7076,
"pull_request": {
"mergeable": true,
"base": {
"repo": {
"owner": {
"login": "servo"
},
"name": "servo"
}
}
},
"action": "ready_for_review"
}
}
24 changes: 24 additions & 0 deletions handlers/status_update/tests/unmergeable_pr_ready_for_review.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"expected": {
"labels": [
"S-awaiting-review",
"S-needs-rebase"
]
},
"initial": {},
"payload": {
"number": 7076,
"pull_request": {
"mergeable": false,
"base": {
"repo": {
"owner": {
"login": "servo"
},
"name": "servo"
}
}
},
"action": "ready_for_review"
}
}
Loading