-
Notifications
You must be signed in to change notification settings - Fork 9
2025 11 15 96o6 91a92 #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge pull request #68 from seqasim/2025-11-15-96o6-91a92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: NameError: Variable from Unquoted String
The condition elif entorhinal in roi: references an undefined variable entorhinal (missing quotes). This should be the string 'entorhinal' to check if the string is in the roi list. This will cause a NameError at runtime when this branch is executed.
LFPAnalysis/analysis_utils.py#L154-L155
LFPAnalysis/LFPAnalysis/analysis_utils.py
Lines 154 to 155 in 473232a
| roi += ['cingulate gyrus a', 'cingulate gyrus b', 'cingulate gyrus c'] | |
| elif entorhinal in roi: |
| spikes - raw spike times used to compute STA, should be in s | ||
| signal - signal for averaging. can be filtered or unfiltered. | ||
| bound - bound of the STA in ms, +- this number | ||
| def lfp_sta(ev_times: np.ndarray, signal: np.ndarray, sr: float, pre: float, post: float): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| spikes - raw spike times used to compute STA, should be in s | ||
| signal - signal for averaging. can be filtered or unfiltered. | ||
| bound - bound of the STA in ms, +- this number | ||
| def lfp_sta(ev_times: np.ndarray, signal: np.ndarray, sr: float, pre: float, post: float): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge pull request #70 from seqasim/2025-11-15-96o6-91a92
accidental branch - merge
Note
Add comprehensive type hints and docstrings plus a suite of LFP analysis utilities (preprocessing/baseline, BOSC/eBOSC, connectivity incl. GC/GCMI and amp coupling, FOOOF, synchronization, NLX/IOWA parsing, and permutation/mixed-effects stats).
Written by Cursor Bugbot for commit 473232a. This will update automatically on new commits. Configure here.