Replaced RxJava with Coroutines#22
Open
GuilhE wants to merge 4 commits intosephiroth74:masterfrom
GuilhE:master
Open
Replaced RxJava with Coroutines#22GuilhE wants to merge 4 commits intosephiroth74:masterfrom GuilhE:master
GuilhE wants to merge 4 commits intosephiroth74:masterfrom
GuilhE:master
Conversation
GuilhE
commented
Jan 21, 2020
GuilhE
commented
- Replaced RxJava dependency with coroutines;
- Removed dependencies being added by sephirith74 imported libs;
- Cleanup all warnings;
- Reformat Code task;
- Lib version bump;
- Gradle versions bump;
- Travis update;
- Removed RxJava dependency with coroutines; - Removed dependencies being added by sephirith74 imported libs; - Cleanup all warnings; - Reformat Code task; - Lib version bump; - Gradle versions bump;
Author
|
@sephiroth74 Do you find this PR useful? Can it be merged? |
|
found an issue with coroutines |
- Bug fixed regarding buttonIntervalJob not being cancelled inside downButton.setOnTouchListener MotionEvent.ACTION_DOWN - Gradle, wrapper and dependencies update
Author
Fixed |
This was referenced Feb 18, 2021
|
why not merge ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.