This repository was archived by the owner on Jul 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
[WIP] Restructure Webhook docs #4
Open
marcokrikke
wants to merge
21
commits into
development
Choose a base branch
from
fb_clean-up-webhook-docs
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange.Schedule.Date.
Do not use the discriminator to be able to select the type of payload. Echo does not know about this. Now documenting the payloads separately.
…yload_TimetableChange and refer it from well known notification types.
…able_change_event_attribute and ping_response into their respective schema objects. They were only used once.
Mostly wording.
…g definitions to introduction.
Member
Author
|
@evpaassen dit is dus jouw werk, maar dan in aparte commits. De commits "Minor documentation improvements" en "Restructured and fine-tuned introductory sections" bevatten de meeste changes die ik gemaakt heb. |
|
@marcokrikke wat is de status van deze vergaarbak? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. eveoh/echo#194
Proposed changes
In general, the following changes have been made (mostly work by @evpaassen):
No API changes have been made.
Testing
Locally built the documentation. Visual checks.
Upgrade notes for breaking changes
UPGRADE_NOTES.mdhas been updated (when applicable).