Skip to content

feat: prevent sending empty messages to sender/player #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodfishBender wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: prevent sending empty messages to sender/player #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../advancedportals/legacyspigot/connector/container/LegacySpigotCommandSenderContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.sekwah.advancedportals.core.connector.containers.CommandSenderContainer;
import com.sekwah.advancedportals.core.connector.containers.ServerContainer;
import com.sekwah.advancedportals.core.util.Lang;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;

Expand All @@ -14,6 +15,9 @@ public LegacySpigotCommandSenderContainer(CommandSender commandSender) {
}

public void sendMessage(String message) {
if (message.isBlank()
|| message.equals(Lang.getPositivePrefix())
|| message.equals(Lang.getNegativePrefix())) return;
sender.sendMessage(message);
}

Expand Down
4 changes: 4 additions & 0 deletions .../sekwah/advancedportals/legacyspigot/connector/container/LegacySpigotPlayerContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import com.sekwah.advancedportals.core.connector.containers.ServerContainer;
import com.sekwah.advancedportals.core.serializeddata.PlayerLocation;
import com.sekwah.advancedportals.core.serializeddata.Vector;
import com.sekwah.advancedportals.core.util.Lang;
import com.sekwah.advancedportals.legacyspigot.AdvancedPortalsPlugin;
import com.sekwah.advancedportals.shadowed.inject.Inject;
import java.awt.*;
Expand Down Expand Up @@ -44,6 +45,9 @@ public UUID getUUID() {

@Override
public void sendMessage(String message) {
if (message.isBlank()
|| message.equals(Lang.getPositivePrefix())
|| message.equals(Lang.getNegativePrefix())) return;
player.sendMessage(message);
}

Expand Down
4 changes: 4 additions & 0 deletions ...a/com/sekwah/advancedportals/spigot/connector/container/SpigotCommandSenderContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.sekwah.advancedportals.core.connector.containers.CommandSenderContainer;
import com.sekwah.advancedportals.core.connector.containers.ServerContainer;
import com.sekwah.advancedportals.core.util.Lang;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;

Expand All @@ -13,6 +14,9 @@ public SpigotCommandSenderContainer(CommandSender commandSender) {
}

public void sendMessage(String message) {
if (message.isBlank()
|| message.equals(Lang.getPositivePrefix())
|| message.equals(Lang.getNegativePrefix())) return;
sender.sendMessage(message);
}

Expand Down
4 changes: 4 additions & 0 deletions ...ain/java/com/sekwah/advancedportals/spigot/connector/container/SpigotPlayerContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import com.sekwah.advancedportals.core.connector.containers.ServerContainer;
import com.sekwah.advancedportals.core.serializeddata.PlayerLocation;
import com.sekwah.advancedportals.core.serializeddata.Vector;
import com.sekwah.advancedportals.core.util.Lang;
import com.sekwah.advancedportals.shadowed.inject.Inject;
import com.sekwah.advancedportals.spigot.AdvancedPortalsPlugin;
import java.awt.*;
Expand Down Expand Up @@ -44,6 +45,9 @@ public UUID getUUID() {

@Override
public void sendMessage(String message) {
if (message.isBlank()
|| message.equals(Lang.getPositivePrefix())
|| message.equals(Lang.getNegativePrefix())) return;
player.sendMessage(message);
}

Expand Down