Merged
Conversation
Contributor
wenxi-zeng
commented
Jun 26, 2025
wenxi-zeng
commented
- make sure metric plugin is loaded as long as destination filters plugin is loaded
- update the dependencies to the latest that have critical fix to filters
- settings now propagate to filters regardless of network status
- update is called now every time the app is brought to foreground with fresh settings
- filters of dropping event now no longer logs null cast exception
- add cache to avoid filters being removed and added repeatedly when update is called
Comment on lines
78
to
80
| // if engine recreated or rules are different we need to remove and recreated filters | ||
| // otherwise, we can skip | ||
| if (!engineRecreated && !cacheInvalidated) return |
Contributor
There was a problem hiding this comment.
This comment is confusing because it's talking in the affirmative but the variables are negated. Maybe something like:
// If the engine has NOT been recreated and the cache/rules have not been invalidated then we can exit early.
didiergarcia
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.