fix(media-request-subscriber): prevent mediald nullification from cascade saves #2356

fallenbagel · 2026-01-29T16:58:46Z

Description

The mediaId FK on media_request rows was being set to NULL shortly after insert. This was caused by mediaRepository.save(media) being called with the requests relation loaded, which triggered TypeORM's cascade ['insert', 'update'] reconciliation on all loaded request entities, corrupting the FK. The issue was compounded by these saves not being awaited in updateParentStatus, creating race conditions between concurrent subscriber methods (updateParentStatus, sendToSonarr, sendToRadarr) all firing from afterInsert.

Additionally, previously, declining a TV request did not reset the associated season statuses back to UNKNOWN, preventing those seasons from being re-requested. The pending request count check also did not exclude the request being declined or scope to the correct is4k variant, causing the media status to remain stuck at PENDING.

Related to #2316

[info][Media Request]: Sent request to Sonarr {"requestId":2871,"mediaId":3802}
[info][Media Request]: Sent request to Sonarr {"requestId":2872,"mediaId":3803}
[info][Media Request]: Sent request to Sonarr {"requestId":2873,"mediaId":3804}

Yet the database showed NULL for the mediaId column on those same records:

  id  | mediaId |           createdAt           
------+---------+-------------------------------
 2871 |         | 2026-01-28 04:35:16.162949+00
 2872 |         | 2026-01-28 04:37:23.039107+00
 2873 |         | 2026-01-28 04:45:12.229032+00

How Has This Been Tested?

Auto-approved request (movie & TV): mediaId not null
Pending request → manual approve: sent to Radarr/Sonarr, notifications fire
Decline movie request: media status resets to UNKNOWN
Decline TV request (last pending): media status resets to UNKNOWN
Decline TV request (other pending exists): media status stays PENDING
Decline TV request: season statuses reset, can re-request
Delete a request: media status resets appropriately

Screenshots / Logs (if applicable)

Checklist:

I have read and followed the contribution guidelines.
Disclosed any use of AI (see our policy)
I have updated the documentation accordingly.
All new and existing tests passed.
Successful build pnpm build
Translation keys pnpm i18n:extract
Database migration (if required)

gauthier-th · 2026-01-29T16:59:41Z

Related to #2316

Copilot

Pull request overview

Fixes an intermittent TypeORM relation-mapping issue that could create media_request rows with a NULL mediaId, leading to orphaned requests and frontend crashes when request.media is missing.

Changes:

Adds an explicit @JoinColumn({ name: 'mediaId' }) to the MediaRequest.media relation.
Removes the separate mediaId column/property and stops manually setting mediaId during request creation, relying on the relation mapping instead.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

server/entity/MediaRequest.ts

github-actions · 2026-02-04T16:54:12Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

server/subscriber/MediaRequestSubscriber.ts

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

server/subscriber/MediaRequestSubscriber.ts

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/components/RequestModal/TvRequestModal.tsx

server/subscriber/MediaRequestSubscriber.ts

Fixes intermittent NULL mediaId foreign key on media_request records byadding explicit @joincolumn decorator to the media relation. Without this,TypeORM's implicit FK mapping was unreliable, causing orphaned requeststhat would crash the frontend when accessing user profiles. Also removes the redundant @column decorator for mediaId which conflicted withthe relation, and removes explicit mediaId assignments in the constructorwhich are now handled correctly by TypeORM through the relation.

…n mapping issue

… mapping

… instances

…eORM mapping

…gging

…cade saves The mediaId FK on `media_request` rows was being set to NULL shortly after insert caused by `mediaRepository.save(media)` being called with the requests relation loaded which in turn triggered TypeORM's cascade reconciliation on all loaded request entities, corrupting the FK. This issue must have even gotten worse when the saves were not being awaited in updateParentStatus which could have caused race conditions between concurrent subscriber methods (updateParentStatus, sendToSonarr, sendToRadarr) all firing from afterInsert. fix #2315

…& afterUpdate

…request status updates

refactor: more loggssss fix: pOTENTIAL FIX

…is declined

…r active requests exist

server/subscriber/MediaRequestSubscriber.ts

fallenbagel requested a review from a team as a code owner January 29, 2026 16:58

fallenbagel requested a review from Copilot January 29, 2026 17:15

Copilot started reviewing on behalf of fallenbagel January 29, 2026 17:15 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

server/entity/MediaRequest.ts Show resolved Hide resolved

fallenbagel mentioned this pull request Feb 4, 2026

revert(media-request): revert #2316 explicitly setting the mediaId when creating request #2372

Merged

7 tasks

fallenbagel changed the title ~~fix: add explicit JoinClumn to MediaRequest media relation~~ fix: try to fix MediaRequest mediaId null issue Feb 4, 2026

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Feb 4, 2026

fallenbagel force-pushed the fallenbagel/fix/typeorm-mediaid-null-issue branch 2 times, most recently from 63b6433 to a74b313 Compare February 5, 2026 06:37

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Feb 5, 2026

fallenbagel force-pushed the fallenbagel/fix/typeorm-mediaid-null-issue branch from a74b313 to c5479c0 Compare February 5, 2026 06:42

fallenbagel changed the title ~~fix: try to fix MediaRequest mediaId null issue~~ fix(media-request-subscriber): prevent mediald nullification from cascade saves Feb 6, 2026

fallenbagel added the bug Something isn't working label Feb 7, 2026

fallenbagel requested a review from Copilot February 7, 2026 01:32

Copilot started reviewing on behalf of fallenbagel February 7, 2026 01:33 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

fallenbagel requested a review from Copilot February 7, 2026 02:06

Copilot started reviewing on behalf of fallenbagel February 7, 2026 02:06 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

fallenbagel force-pushed the fallenbagel/fix/typeorm-mediaid-null-issue branch from 03ad825 to d78a996 Compare February 7, 2026 04:06

fallenbagel requested a review from Copilot February 8, 2026 06:10

Copilot started reviewing on behalf of fallenbagel February 8, 2026 06:11 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

src/components/RequestModal/TvRequestModal.tsx Outdated Show resolved Hide resolved

server/subscriber/MediaRequestSubscriber.ts Show resolved Hide resolved

fallenbagel force-pushed the fallenbagel/fix/typeorm-mediaid-null-issue branch from 7de1b36 to 902a69c Compare February 8, 2026 09:48

fallenbagel added 4 commits February 9, 2026 19:33

fix(media-request): set mediaId explicitly to resolve TypeORM relatio…

58934d0

…n mapping issue

fix(media-request): resolve mediaId null value using read-only column…

15b017c

… mapping

fix(media-request): set mediaId explicitly when creating MediaRequest…

c79f2a5

… instances

fallenbagel added 9 commits February 9, 2026 19:33

fix(media-request): update mediaId handling to use RelationId for Typ…

c1977bb

…eORM mapping

refactor(media-request): remove all fixes and enable verbose debug lo…

064b6ea

…gging

refactor(media-request): remove excessive debug logging

febf82e

fix(media-request-subscriber): better async handling for afterInsert …

c7d6073

…& afterUpdate

fix(media-request-subscriber): improve error handling and logging in …

35050f7

…request status updates

fix: exclude current request from pending count during status updates

a37ee6f

refactor: more loggssss fix: pOTENTIAL FIX

fix(mediarequestsubscriber): reset season statuses when a TV request …

0293632

…is declined

fix(media-request-subscriber): prevent updating season status if othe…

d73f039

…r active requests exist

fallenbagel force-pushed the fallenbagel/fix/typeorm-mediaid-null-issue branch from 902a69c to d73f039 Compare February 9, 2026 11:33

gauthier-th reviewed Feb 9, 2026

View reviewed changes

server/subscriber/MediaRequestSubscriber.ts Show resolved Hide resolved

server/subscriber/MediaRequestSubscriber.ts Show resolved Hide resolved

server/subscriber/MediaRequestSubscriber.ts Show resolved Hide resolved

server/subscriber/MediaRequestSubscriber.ts Show resolved Hide resolved

gauthier-th previously approved these changes Feb 9, 2026

View reviewed changes

fallenbagel mentioned this pull request Feb 12, 2026

Deleting media triggers erroneous 'Available' notifications for requests migrated from Overseerr #2408

Closed

2 tasks

M0NsTeRRR reviewed Feb 13, 2026

View reviewed changes

server/subscriber/MediaRequestSubscriber.ts Outdated Show resolved Hide resolved

M0NsTeRRR previously approved these changes Feb 13, 2026

View reviewed changes

refactor: cleanup leftover code from old changes

68011ce

fallenbagel dismissed stale reviews from M0NsTeRRR and gauthier-th via 68011ce February 13, 2026 09:46

fallenbagel requested review from M0NsTeRRR and gauthier-th February 13, 2026 09:46

gauthier-th approved these changes Feb 13, 2026

View reviewed changes

M0NsTeRRR approved these changes Feb 13, 2026

View reviewed changes

fallenbagel merged commit 1ed86c1 into develop Feb 13, 2026
10 checks passed

fallenbagel deleted the fallenbagel/fix/typeorm-mediaid-null-issue branch February 13, 2026 10:02

Uh oh!

fix(media-request-subscriber): prevent mediald nullification from cascade saves #2356

fix(media-request-subscriber): prevent mediald nullification from cascade saves #2356

Conversation

fallenbagel commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Screenshots / Logs (if applicable)

Checklist:

Uh oh!

gauthier-th commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fallenbagel commented Jan 29, 2026 •

edited

Loading