Merged
Conversation
Owner
|
@fanshi1028 Thanks for submitting this. Did you run through all the examples to test? I'm getting a couple Typescript errors on your branch. Can you fix please? Do we have a typescript version mismatch or somethign? |
Contributor
Author
Oops. I just tsc-ed it and didn't even try to build with webpack. But I have just fixed them for webpack build and checked to ensured the demo app's examples do works. Please check again. |
seanhess
requested changes
Mar 5, 2026
| export function listenChange(cb: (target: HyperView, action: string) => void): void { | ||
| document.addEventListener("change", function(e) { | ||
| let el = e.target as HTMLElement | ||
| if (!(e.target instanceof HTMLElement)) { |
| document.addEventListener("input", function(e) { | ||
| let el = e.target as HTMLElement | ||
| let source = el.closest("[data-oninput]") as LiveInputElement | ||
| if (!(e.target instanceof HTMLElement)) { |
| export function listenFormSubmit(cb: (target: HyperView, action: string, form: FormData) => void): void { | ||
| document.addEventListener("submit", function(e) { | ||
| let form = e.target as HTMLFormElement | ||
| if (!(e.target instanceof HTMLFormElement)) { |
… to nearestAnyTarget
Changed logging level from error to warn when event handlers receive non-HTMLElement targets, and standardized log messages using %o formatter for better object inspection.
This reverts commit 51cb0bb.
Contributor
Author
|
@seanhess Please check my replies and changes and tell me what to do next(if any). |
Owner
|
Thanks for your hard work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.