Add early processing to scheduler tests. Stop saving empty results for early processing.#68
Add early processing to scheduler tests. Stop saving empty results for early processing.#68JDuchniewicz wants to merge 3 commits intoseL4:masterfrom
Conversation
55b8897 to
c09e313
Compare
Adds early processing to scheduler benchmarks. Signed-off-by: Jakub Duchniewicz <[email protected]>
Signed-off-by: Jakub Duchniewicz <[email protected]>
Signed-off-by: Jakub Duchniewicz <[email protected]>
|
@lsf37 It's been pending for a while. Would you have a look at that? It's not crucial but definitiely improves the benchmarking in general. |
There was a problem hiding this comment.
Looks okay.
Main thing I don't like is doing the same thing twice in slightly different ways, but that applies to all early processing stuff, not just this one.
Just make a choice between early processing or no early processing, whichever is better. Why would the user be interested in the same benchmark done slightly differently?
I'd like to see some before and after numbers for these changes for multiple platforms, if possible.
My main problem with this whole early processing thing is that it adds a lot of complexity, while all that's needed for the existing benchmarks to be stable is to zero the result array before starting the benchmark, to make it cache hot.
Edit: Oh, and a check for overflows would be nice to catch problems with large numbers of runs.
This PR adds missing early processing for two benchmarks:
It also: