Fix swapped results arrays in early-proc for sync benchmarks#67
Open
JDuchniewicz wants to merge 2 commits intoseL4:masterfrom
Open
Fix swapped results arrays in early-proc for sync benchmarks#67JDuchniewicz wants to merge 2 commits intoseL4:masterfrom
JDuchniewicz wants to merge 2 commits intoseL4:masterfrom
Conversation
Signed-off-by: Jakub Duchniewicz <[email protected]>
lsf37
approved these changes
Dec 18, 2025
Member
lsf37
left a comment
There was a problem hiding this comment.
Thanks for catching that. Looks good from my side.
Indanz
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at
sel4bench/apps/sync/src/main.c
Line 199 in 05b7569
sel4bench/apps/sync/src/main.c
Line 258 in 05b7569
The results are accidentally swapped for the EP version of benchmark. This PR fixes that.
The results before the change (run for odroid_c2):
One can clearly see that the early processing labels are swapped.
We still have a large spike from the last sample in the Producer to consumer case but I don't really know how to fix it easily.