Draft
Conversation
Member
|
This needs more work. If we change something, we need to change it both in the deployment workflow and the PR workflow. We don't want them to go out of sync and test different things. I also don't like the suffix hack. If we do this, the compiler should be properly part of the image name. If we want to do only one run, we can add a fixed |
Member
Author
|
Making this a draft PR for now. Currently, my main motivation for having a clang build also is to see, if this reports something other than the gcc build. And to get more insight in how the github ci actions work. |
dd17585 to
897d13e
Compare
810af83 to
4118916
Compare
46fd8d8 to
9596452
Compare
c9ac30f to
667932b
Compare
Signed-off-by: Axel Heider <[email protected]>
3ec8206 to
3b8b973
Compare
added 4 commits
April 18, 2024 14:43
Signed-off-by: Axel Heider <[email protected]>
needed unless KernelFWholeProgram is fixed Signed-off-by: Axel Heider <[email protected]>
Signed-off-by: Axel Heider <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses parts of #21 and adds a build with clang. The resulting archive gets the suffix
-clang. Forgccbuilds no suffix is used to avoid breaking any existing workflows.