Open
Conversation
Member
|
Good to see the old domain tests failing -- that means we're actually doing something :). This should disappear once we've updated sel4test accordingly. |
Indanz
force-pushed
the
domain
branch
3 times, most recently
from
cf74237 to
5a31b7d
Compare
Contributor
Author
|
Main changes:
|
lsf37
reviewed
Dec 15, 2025
lsf37
reviewed
Dec 15, 2025
lsf37
reviewed
Dec 15, 2025
lsf37
reviewed
Dec 15, 2025
lsf37
reviewed
Dec 15, 2025
lsf37
reviewed
Dec 15, 2025
lsf37
reviewed
Dec 15, 2025
Member
lsf37
left a comment
lsf37
left a comment
There was a problem hiding this comment.
This is looking good to me and is implementing the RFC as approved. Will leave out the tick for now so we don't accidentally merge before verification is finished.
lsf37
added
the
verification
Member
Given that the change is only breaking if you are using the kernel API directly, we should at least have a deprecation period for the old |
Xaphiosis
reviewed
Dec 17, 2025
Xaphiosis
reviewed
Dec 17, 2025
Xaphiosis
reviewed
Dec 17, 2025
Xaphiosis
reviewed
Dec 17, 2025
Xaphiosis
reviewed
Dec 17, 2025
Xaphiosis
reviewed
Dec 17, 2025
Indanz
force-pushed
the
domain
branch
2 times, most recently
from
8478ad1 to
dc84b9b
Compare
Implements RFC-20. Signed-off-by: Indan Zupancic <[email protected]>
Useful for configuring domains. Signed-off-by: Indan Zupancic <[email protected]>
lsf37
reviewed
Jan 19, 2026
| #define DSCHED_MAX_DURATION (UINT64_MAX >> DSCHED_DOMAIN_BITS) | ||
| #define DSCHED_DURATION_MASK DSCHED_MAX_DURATION | ||
|
|
||
| static dschedule_t dschedule_make(dom_t domain, uint64_t duration) |
Member
There was a problem hiding this comment.
Suggested change
| static dschedule_t dschedule_make(dom_t domain, uint64_t duration) | |
| static inline dschedule_t dschedule_make(dom_t domain, uint64_t duration) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RFC-20.
TODO:
DomainSetSettoDomainSet?